Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support concordance and alignment API endpoints #40

Merged

Conversation

laasem
Copy link
Contributor

@laasem laasem commented Mar 19, 2023

Addresses #39 by adding the following 3 new API endpoints and their corresponding unit tests:

@andrii-bodnar
Copy link
Member

@laasem thanks a lot for your contribution!

The CI has failed, could you please take a look? https://github.com/crowdin/crowdin-api-client-ruby/actions/runs/4462294126

Most of the CI issues seem related to the quotes style.

@andrii-bodnar andrii-bodnar linked an issue Mar 20, 2023 that may be closed by this pull request
@laasem
Copy link
Contributor Author

laasem commented Mar 20, 2023

@andrii-bodnar Thanks for your comments! I've addressed them; however, the linting still fails due to the two wrapper describe blocks in glossaries_spec.rb being too long. Would you suggest breaking them up as part of this PR or a separate one?

@andrii-bodnar
Copy link
Member

@laasem I think that the best option here is to break the Default endpoints into smaller groups of endpoints. For example, Default endpoints (all the glossary-related endpoints including new concordance search), Concept endpoints, Term endpoints

@andrii-bodnar
Copy link
Member

It would be great if you could do it within the current PR, just to not break the main pipeline

@laasem
Copy link
Contributor Author

laasem commented Mar 21, 2023

@andrii-bodnar Thanks for your suggestion - I've implemented it and I think it should work now.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #40 (cd7407f) into main (10aa2b8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head cd7407f differs from pull request most recent head 9e030f5. Consider uploading reports for the commit 9e030f5 to get more accurate results

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   97.88%   97.92%   +0.05%     
==========================================
  Files          57       57              
  Lines        2588     2643      +55     
==========================================
+ Hits         2533     2588      +55     
  Misses         55       55              
Impacted Files Coverage Δ
lib/crowdin-api/api_resources/glossaries.rb 98.97% <100.00%> (+0.07%) ⬆️
...b/crowdin-api/api_resources/string_translations.rb 98.72% <100.00%> (+0.11%) ⬆️
...ib/crowdin-api/api_resources/translation_memory.rb 100.00% <100.00%> (ø)
spec/api_resources/glossaries_spec.rb 100.00% <100.00%> (ø)
spec/api_resources/string_translations_spec.rb 100.00% <100.00%> (ø)
spec/api_resources/translation_memory_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Member

@laasem thanks a lot for the contribution, looks good to me! 🚀

@andrii-bodnar andrii-bodnar merged commit 5cd45c5 into crowdin:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New API Endpoints (concordance, alignment)
2 participants