-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support concordance and alignment API endpoints #40
feat: Support concordance and alignment API endpoints #40
Conversation
@laasem thanks a lot for your contribution! The CI has failed, could you please take a look? https://github.com/crowdin/crowdin-api-client-ruby/actions/runs/4462294126 Most of the CI issues seem related to the quotes style. |
@andrii-bodnar Thanks for your comments! I've addressed them; however, the linting still fails due to the two wrapper describe blocks in glossaries_spec.rb being too long. Would you suggest breaking them up as part of this PR or a separate one? |
@laasem I think that the best option here is to break the |
It would be great if you could do it within the current PR, just to not break the |
@andrii-bodnar Thanks for your suggestion - I've implemented it and I think it should work now. |
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 97.88% 97.92% +0.05%
==========================================
Files 57 57
Lines 2588 2643 +55
==========================================
+ Hits 2533 2588 +55
Misses 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@laasem thanks a lot for the contribution, looks good to me! 🚀 |
Addresses #39 by adding the following 3 new API endpoints and their corresponding unit tests: