-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bundle API #48
feat: bundle API #48
Conversation
Add export_bundle and download_bundle methods
Hi @Halle, thanks for the contribution! Could you please address the failed CI/CD checks? https://github.com/crowdin/crowdin-api-client-ruby/actions/runs/5276119680/jobs/9542505611?pr=48 |
@Halle It would be also great to add the Check Bundle Export Status. The Export Bundle, Check Bundle Export Status, and Download Bundle methods are supposed to work together. The Download Bundle itself doesn't make a lot of sense because we need to check the export status, ensure that it's finished, and then we can finally download it. Could you also add this method? Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 97.92% 97.96% +0.04%
==========================================
Files 57 57
Lines 2643 2683 +40
==========================================
+ Hits 2588 2628 +40
Misses 55 55
|
@Halle thanks for the PR update. There are still a couple of CI issues, please take a look |
Hi @andrii-bodnar, it isn't actually clear to me why the two rspec failures are occurring. Do you see it and can you make a code suggestion? |
@Halle currently, I see only the failing check regarding trailing whitespaces. See my code suggestion - #48 (comment) |
Co-authored-by: Andrii Bodnar <[email protected]>
Hi @andrii-bodnar, sorry, adding and real-world-testing |
@Halle thank you! |
Co-authored-by: Andrii Bodnar <[email protected]>
Co-authored-by: Andrii Bodnar <[email protected]>
Co-authored-by: Andrii Bodnar <[email protected]>
Co-authored-by: Andrii Bodnar <[email protected]>
Greetings,
Due to our local requirements I added bundle export and bundle download to our fork, and wanted to offer this PR in case you also wanted to support them as a client feature. I've been using these methods in our automation for six weeks and it seems to function well, and similarly to the rest of the client. I can't offer to write more unit tests right now, but if someone else wants to contribute them to finish up the PR if that is an acceptance requirement, I welcome it.
Thanks,
Halle