fix(bundles): add destination parameter #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the destination parameter to the download_bundle method.
|
@araujotadeu the tests have failed, could you please take a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 98.08% 98.08%
=======================================
Files 61 61
Lines 2810 2810
=======================================
Hits 2756 2756
Misses 54 54 ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Apr 17, 2024
andrii-bodnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing destination parameter to the download_bundle method.
Due to the changes made in the 1.8.0 release for the download methods. Related discussion - #66 and PR - #69.
Because of those changes the download_bundle method also needs the destination parameter now. Source discussion of the change #83