Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #344

Merged
merged 9 commits into from
Feb 22, 2021
Merged

Improvements #344

merged 9 commits into from
Feb 22, 2021

Conversation

frombetelgeuse
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #344 (c21ef70) into cli3 (0c9c5b8) will decrease coverage by 0.37%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               cli3     #344      +/-   ##
============================================
- Coverage     60.90%   60.53%   -0.36%     
- Complexity      847      853       +6     
============================================
  Files           139      139              
  Lines          3951     3985      +34     
  Branches        568      569       +1     
============================================
+ Hits           2406     2412       +6     
- Misses         1263     1287      +24     
- Partials        282      286       +4     
Impacted Files Coverage Δ Complexity Δ
...main/java/com/crowdin/cli/properties/FileBean.java 61.62% <0.00%> (ø) 21.00 <0.00> (ø)
...va/com/crowdin/cli/properties/ParamsWithFiles.java 87.50% <0.00%> (-5.83%) 10.00 <1.00> (+1.00) ⬇️
...in/java/com/crowdin/cli/utils/PlaceholderUtil.java 93.66% <ø> (ø) 27.00 <0.00> (ø)
...com/crowdin/cli/properties/PropertiesBuilders.java 17.15% <50.00%> (-0.50%) 6.00 <3.00> (+1.00) ⬇️
...m/crowdin/cli/commands/actions/DownloadAction.java 73.34% <63.64%> (-1.48%) 39.00 <0.00> (ø)
...wdin/cli/commands/actions/UploadSourcesAction.java 52.54% <81.82%> (+0.88%) 24.00 <5.00> (+3.00)
...a/com/crowdin/cli/commands/actions/CliActions.java 95.46% <100.00%> (ø) 21.00 <1.00> (ø)
...cli/commands/actions/UploadTranslationsAction.java 68.91% <100.00%> (-0.92%) 13.00 <0.00> (ø)
...li/commands/functionality/PropertiesBeanUtils.java 87.88% <100.00%> (+0.38%) 17.00 <1.00> (+1.00)
...din/cli/commands/functionality/RequestBuilder.java 50.50% <100.00%> (+0.50%) 10.00 <0.00> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9c5b8...c21ef70. Read the comment docs.

@andrii-bodnar andrii-bodnar merged commit 5fbaf02 into cli3 Feb 22, 2021
@andrii-bodnar andrii-bodnar deleted the dev branch February 22, 2021 13:17
@slorber
Copy link

slorber commented Feb 22, 2021

Hi

Is there any doc about this improvement? Would be interested to know more details. (edit: the -no-hidden)
Not sure it's what I'm looking for (more interested to avoid downloading hidden strings rather than uploading new strings as hidden by default 🤪 )

(oh I didn't notice this PR contains all the new CLI improvements, thanks 👍 )

@andrii-bodnar
Copy link
Member

Hi @slorber!
There is a list of changes in the release details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants