-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crowdin-cli: Update subdependencies and code for Gradle 7.1 #371
Conversation
Codecov Report
@@ Coverage Diff @@
## cli3 #371 +/- ##
=========================================
Coverage 58.13% 58.13%
Complexity 877 877
=========================================
Files 143 143
Lines 4186 4186
Branches 624 624
=========================================
Hits 2433 2433
Misses 1457 1457
Partials 296 296
Continue to review full report at Codecov.
|
-1, still having some runtime issues. will solve ASAP |
Gradle 6.5.1 is not working with Java 16 (and I couldn't get it working with Java 8 on ArchLinux either). Changes: * Update maven URL to use HTTPS (Gradle 7 requirement). * Update Gradle and wrapper to the latest Version (7.1.1). * Update build.gradle to replace deprecated "enabled" flag with "required". * Update all subdependencies to latest as some required updates for the Gradle update. * Adjust code to match changes between zip4j 1.3.2 and 2.8.0. Tests: Build, Pass tests, run a quick translation pull.
35286cf
to
ecbb381
Compare
Further updated shadow, spotbugs, jacoco and checkstyle as those were incompatible with Java 16 as well. Working fine on my ArchLinux setup now. |
@Myself5 thanks a lot for your contribution! |
@frombetelgeuse please review this PR. |
@Myself5 will it be compatible with previous Gradle and java versions? |
Should be irrelevant, as the included gradle wrapper (which is 7.1) is what downloads Gradle and manages the rest. The "host" version of Gradle should therefore be irrelevant. (e.g. I don't even have gradle installed.)
I've tested it with Java 16 and 8, Compiled it on 16, ran fine on 16 as well as 8, compiled it on 8, ran fine on 16 and 8 as well. Both on a x86_64 system. If there's any other edgecases that might need to be covered, let me know and I'll try. |
@Myself5 merged this PR and discovered that the static analysis job was failed. is there any way to fix this? |
Terribly sorry, I could swear that passed when I tested it. I'll take a look immediately. |
Ok, found it. The Upgrade to Checkstyle 8.44 appears to require some config updates, it's working fine with 8.34. Will check on which changes are required and open another PR. |
Fixed in #373 |
Gradle 6.5.1 is not working with Java 16 (and I couldn't get it working with Java 8 on ArchLinux either).
Changes:
Tests: Build, Pass tests, run a quick translation pull.