Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downloading multiple specified languages #493

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

Epicpkmn11
Copy link
Contributor

  • Adds the ability to download mutiple specified languages by doing, for example, crowdin pull -l de -l ja -l he
  • I've run the unit tests and it passes, however tbh I don't really understand what's going on in the tests file so I don't know how to add a new test to check for this new feature
  • Closes Option to download multiple specific languages #427

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #493 (f16e05d) into cli3 (46b11ec) will decrease coverage by 0.14%.
The diff coverage is 36.37%.

@@             Coverage Diff              @@
##               cli3     #493      +/-   ##
============================================
- Coverage     56.25%   56.12%   -0.13%     
  Complexity      963      963              
============================================
  Files           153      153              
  Lines          4772     4769       -3     
  Branches        732      735       +3     
============================================
- Hits           2684     2676       -8     
- Misses         1735     1737       +2     
- Partials        353      356       +3     
Impacted Files Coverage Δ
...m/crowdin/cli/commands/actions/DownloadAction.java 70.51% <22.23%> (-1.97%) ⬇️
...a/com/crowdin/cli/commands/actions/CliActions.java 80.77% <100.00%> (ø)
...owdin/cli/commands/picocli/DownloadSubcommand.java 85.72% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Member

@Epicpkmn11 thanks a lot for your contribution! 🎉

I will pass this PR for a quick test to our QA team and then will come back to you

@andrii-bodnar andrii-bodnar merged commit ed2c218 into crowdin:cli3 Oct 17, 2022
@andrii-bodnar andrii-bodnar mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to download multiple specific languages
2 participants