fix: Upgrade Gradle and dependencies to fix Java 20 #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Myself5, thanks a lot for your contribution! it looks interesting There are failed CI/CD checks in this PR, could you please take a look? Thanks |
|
Also, I am wondering if it will be backward compatible with the previous CLI installations |
|
Hey @andrii-bodnar, working on the CI/CD issues. I don't quite see how it would break any kind of previous CLI installations it only updates deps and the gradle tool similiar to what I did before, just that this time I added the refreshVersions module to make updating the dep-versions easier in the future. |
Myself5
changed the title
Myself5
force-pushed
the
gradle-8.1.1+refreshVersions
branch
from
2501958 to
db73f88
Compare
Codecov Report
@@ Coverage Diff @@
## cli3 #573 +/- ##
=========================================
Coverage 61.52% 61.52%
Complexity 1150 1150
=========================================
Files 171 171
Lines 5044 5044
Branches 770 770
=========================================
Hits 3103 3103
Misses 1520 1520
Partials 421 421 |
* Add and configure [refreshVersions](https://jmfayard.github.io/refreshVersions/) module to update dependencies * Update dependencies to latest version for Gradle compatibility * Update Gradle to version 8.1.1 Note: Jacoco can not be automatically updated by the update and its version will need to be updated in the versions.properties manually. Test: Build and run on ArchLinux using OpenJDK 20.0.1.
Myself5
force-pushed
the
gradle-8.1.1+refreshVersions
branch
from
db73f88 to
49f8a73
Compare
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Jacoco can not be automatically updated by the update and its version will need to be updated in the versions.properties manually.
Test: Build and run on ArchLinux using OpenJDK 20.0.1.