Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internalTests schema object to merge schemas method #60

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

vojnovicluka
Copy link
Collaborator

@vojnovicluka vojnovicluka commented Apr 10, 2024

Basic information

@croz/nrich-form-configuration-core: v3.0.0

Additional information

Description

Summary

An enhancement has been made to the schema merger function to address its previous limitations when using "yup" required() validator function.

Details

Related issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 6ce2e3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@croz/nrich-form-configuration-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (fc9299b) to head (6ce2e3b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   99.00%   99.01%           
=======================================
  Files          25       25           
  Lines         202      203    +1     
  Branches       32       32           
=======================================
+ Hits          200      201    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vojnovicluka vojnovicluka force-pushed the feature_fixFormConfigurationMergeSchemas branch 2 times, most recently from 5d99473 to b332677 Compare April 10, 2024 13:32
@vojnovicluka vojnovicluka force-pushed the feature_fixFormConfigurationMergeSchemas branch from b332677 to 6ce2e3b Compare April 11, 2024 06:29
@jtomic-croz jtomic-croz merged commit 9767c6c into master Apr 11, 2024
1 check passed
@jtomic-croz jtomic-croz deleted the feature_fixFormConfigurationMergeSchemas branch April 11, 2024 06:31
@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants