New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#241 Fix bug when Breadcrumbs icon is rendered between non-rendered elements #242

Merged

jtomic-croz merged 1 commit into master from bugfix/241

Apr 23, 2024

Collaborator

LukaFilipovic99 commented Apr 19, 2024 •

edited

Loading

Basic information

Tiller version:
1.12.0
Module:
core

Additional information

Description

Summary

Fixed a bug when icon is rendered between non-rendered elements of Breadcrumbs component.

Details

Added check if child is undefined before rendering breadcrumb icon and breadcrumb child.

Related issue

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have read the project's CONTRIBUTING document
I have checked my code with the project's static analysis tooling
I have formatted my code with the project's Prettier code-style configuration
I have checked my code for misspellings
I have organized my changes in easy-to-follow commits
My change requires a change to the documentation
I have updated the documentation accordingly
I have added a story to cover my changes
All new and existing story tests pass


          #241 Fix bug when Breadcrumbs icon is rendered between non-rendered e…

f64c977

…lements

LukaFilipovic99 requested a review from jtomic-croz

April 19, 2024 13:52

LukaFilipovic99 self-assigned this

jtomic-croz approved these changes

View reviewed changes

jtomic-croz merged commit d385ea8 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet