Feature/Admin CLI enhancements #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could just call it |
|
I like |
ilveroluca
reviewed
Mar 25, 2022
k8s/templates/job-backup.yaml
Outdated
| imagePullPolicy: {{ .Values.lifemonitor.imagePullPolicy }} | ||
| command: ["/bin/sh","-c"] | ||
| args: | ||
| - base_path="/var/data/backup" ; |
There was a problem hiding this comment.
perhaps this code would be easier to maintain if placed in a script in the lifemonitor image that is used to execute this job.
There was a problem hiding this comment.
Script replaced by lm-admin backup command (ee8401a)
ilveroluca
reviewed
Mar 25, 2022
lifemonitor/commands/db.py
Outdated
| file = f"{datetime.now().strftime('%Y%m%d_%H%M%S')}.tar" | ||
| target_path = os.path.join(directory, file) | ||
| cmd = f"PGPASSWORD={params['password']} pg_dump -h {params['host']} -U {params['user']} -F t {params['dbname']} > {target_path}" | ||
| os.system(cmd) |
There was a problem hiding this comment.
The code is not checking the exit code from the called process. Rather than os.system, we'd be better off just using subprocess.check_call.
|
https://crs4.github.io/life_monitor/lm_admin_guide needs to be updated accordingly |
Allow to make (and optionally synch with a remote site via FTP(s)) backups of both RO-Crates and database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a basic
manage.pyscript which acts as entrypoint for the back-end CLI.The available commands are:
Usage: manage.py [OPTIONS] COMMAND [ARGS]... Options: --help Show this message and exit. Commands: api-key Manage admin API keys cache Manage cache db Manage database oauth Manage credentials for OAuth2 clients registry Manage workflow registries task-queue Manage task queueThe current version of the
dbcommand includes all the relevant subcommands to:Finally, the k8s chart includes a configurable CronJob to perform automatic backups on a user-defined cluster volume and, optionally, to sync that volume with a remote site via SFTP.