Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/improve GitHub App installation #270

Merged

Conversation

kikkomep
Copy link
Member

@kikkomep kikkomep commented Nov 14, 2022

This PR introduces a new callback endpoint for the LifeMonitor GitHub App.

The endpoint provides:

  • a feedback to confirm that the installation was successful;
  • an overview of the user's repos where the GitHub App has been installed (with a link to easily jump to those repos on GitHub);
  • three additional control buttons to jump to the LifeMonitor Dashboard, to the GitHub App Global Settings and to the App administration page on GitHub (to add/remove repos to the current installation or to completely uninstall the app from the user account.

Screenshot 2022-11-14 at 16 00 24

"Settings" Button

Screenshot 2022-11-14 at 16 37 45

"Manage" Button

By clicking the Manage button the user will be redirected to the GitHub app administration page:

Screenshot 2022-11-14 at 16 01 59

(fix #253, #254)

Copy link
Member

@simleo simleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The only change I'd make is to have all the links in the feedback page (including the folder icons that link to the repositories) open in new tabs.

@kikkomep
Copy link
Member Author

Looks great! The only change I'd make is to have all the links in the feedback page (including the folder icons that link to the repositories) open in new tabs.

fixed in c068f89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants