Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize repository check modules #275

Merged
merged 10 commits into from
Nov 18, 2022
Merged

Reorganize repository check modules #275

merged 10 commits into from
Nov 18, 2022

Conversation

ilveroluca
Copy link
Member

This PR proposes a solution for issue #246 by reorganizing automated repository check implementations into new modules. The idea is to split the checks into the following categories:

  • general.lm: things specific to LifeMonitor
  • general.metadata: metadata-related checks (e.g., RO-crate properties)
  • general.repo_layout: general repository layout issues, such as missing metadata files or workflow files
  • <one category per supported workflow type -- e.g., galaxy, snakemake)>

The lifemonitor/api/models/issues directory therefore takes the form:

./galaxy
./snakemake
./general
./general/metadata.py
./general/repo_layout.py
./general/experimental.py
./general/lm.py
./__init__.py

The PR changes the generation of check identifiers to use the module+class name rather than converting the class name to snake case (the automated conversion did not work very well).

The PR also proposes fixing for some small type annotation issues and a change to the check finding function (the original presented problems when relative imports were used).

@kikkomep
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants