Reorganize repository check modules #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a solution for issue #246 by reorganizing automated repository check implementations into new modules. The idea is to split the checks into the following categories:
The
lifemonitor/api/models/issues
directory therefore takes the form:The PR changes the generation of check identifiers to use the module+class name rather than converting the class name to snake case (the automated conversion did not work very well).
The PR also proposes fixing for some small type annotation issues and a change to the check finding function (the original presented problems when relative imports were used).