Added Pomodoro options to Jam countdown #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Project > Tools there are a series of options which automatically assign the "end time" for the "jam counter" to a specified number of minutes after the current time. It does some time-zone calculations to make sure this works in local time as the addon was made for local-time calculations. There is a known edge-case with OS.get_time_zone_info where on Windows machines during daylight savings hours, the returned bias is incorrect. This is a currently existing issue with the Godot engine, it is assumed when that issue is resolved, this edge case will be removed too. Current recommended solution: Add a value to the UNIX_TIME_CALC_CORRECTION in the plugin during daylight savings time. There should be enough comments around the calculations to make it make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface: I wasn't sure if you are open to contributions. If not, I'll leave my repo up as an alternative.
Added Pomodoro Feature
Pomodoro is a method of time management that relies on having a short timer. During the timer's countdown you work on whatever task you decided on, then once the timer is up, you stop working and take a break to reflect on what was accomplished.
I modified this addon slightly to allow for
Use
Under Project > Tools there are a number of options for different numbers of minutes for Pomodoro. (Specifically: 5, 25, 45, 60, and 120 minutes).
When the user clicks on that Pomodoro time, the countdown timer is set to the date-time that causes the countdown to count from the desired number of minutes.
Known issues
There is known issue with
OS.get_time_zone_info(). It causes the time zone bias to be incorrect on windows machines during daylight savings time. There is likely a solution for this issue, but ideally this would be resolved on the engine side.Because an offset is stored to offset into local time, the offset could be given an additional offset by any users which do use daylight savings time.
Commit Message
Under Project > Tools there are a series of options which automatically assign the "end time" for the "jam counter" to a specified number of minutes after the current time. It does some time-zone calculations to make sure this works in local time as the addon was made for local-time calculations.
There is a known edge-case with OS.get_time_zone_info where on Windows machines during daylight savings hours, the returned bias is incorrect. This is a currently existing issue with the Godot engine, it is assumed when that issue is resolved, this edge case will be removed too.
Current recommended solution: Add a value to the UNIX_TIME_CALC_CORRECTION in the plugin during daylight savings time. There should be enough comments around the calculations to make it make sense