Setup Github Actions #290
Closed
Setup Github Actions #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds django 3.2 and 4.0 to tox
* Setup tox to display all warnings
* Fixes the following warnings:
RemovedInDjango40Warning: django-admin.py is deprecated in favor of django-admin.
tests/urls.py:11: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
url(r'^ajax_lookups/', include(ajax_select_urls)),
tests.Author: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
RemovedInDjango41Warning: 'ajax_select' defines default_app_config = 'ajax_select.apps.AjaxSelectConfig'. Django now detects this configuration automatically. You can remove default_app_config.
|
You can see the action run on a test PR I made on my own fork https://github.com/andyzickler/django-ajax-selects/actions/runs/1670368955 Here's the run with the failed flake8 command https://github.com/andyzickler/django-ajax-selects/runs/4746163178?check_suite_focus=true |
|
Great! I'm so happy this works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #278
Please review and merge #289 first as this builds on that.
I created a simple GitHub action to run tox in python 3.8, 3.9 and 3.10. It currently only runs the flake8 command in python 3.8 because the other versions were causing an error that I don't understand yet. I think it might be possible to also run flake8 as a separate GitHub action. I'll look into it.
Let me know what you think and if you have any suggestions / changes. This is my first time working with GitHub actions, but so far it seems pretty easy.
This uses the tox-gh-actions plugin to help with the multiple python versions.