Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Deployment on non-root URL path, reintroduce Minimal deployment #34

Open
zhelanov opened this issue Jun 28, 2022 · 3 comments

Comments

@zhelanov
Copy link

zhelanov commented Jun 28, 2022

Hello!
Thanks for your project - it's awesome!

I'm trying to apply it in my K8S installation and it would be cool to have a few more options to configure:

  1. Disable Grafana container entirely (in a case when we use something else or just don't need Grafana here)
  2. Override the root web URL path (from "/" to "/cryostat", for instance)
  3. Volumes for recordings

Thanks in advance!

@ebaron
Copy link
Member

ebaron commented Jun 29, 2022

Hi @zhelanov, thanks for trying out our Helm chart!

  • Disable Grafana container entirely (in a case when we use something else or just don't need Grafana here)

I've filed a new issue for this. It's something our operator can do, but it should be feasible to implement here as well.

  • Override the root web URL path (from "/" to "/cryostat", for instance)

I've run into trouble before when trying to use an ingress with a path like this. @andrewazores do you know if this is still an issue or how difficult it would be to use a hostname with a path?

  • Volumes for recordings

This should be taken care of with #5. It shouldn't be too much work to implement.

@andrewazores
Copy link
Member

I haven't looked at that in a long time. I don't think it should be too much of an issue though - I would assume that the routers in Vert.x and React both know how to handle that, or can do so without too much extra work.

@andrewazores
Copy link
Member

  1. Disabling the Grafana integration was done for 2.4, but for 3.0 the ability has been removed from both -helm and -operator - Grafana is always deployed now. This is because we've made improvements and added new features to the Grafana dashboard, as well as beta features that place Grafana panels directly in the Cryostat dashboard, so the integration is a little more tightly knit than it used to be. It's still possible to remove them manually when using the Helm chart (or otherwise manually deploying), there just is not a single configuration property for it.
  2. This is actually harder than it sounded at first: [Request] Ability to deploy on paths other than the root / cryostat#262 . It might be achievable by configuring the auth proxy that now sits in front of Cryostat (3.0+), but this needs some more investigation.
  3. Done in 2.4, and redone in 3.0.

I'll leave this open for now to track item 2 (integrating the context path change with the Helm configuration). Unless there are a lot of requests for item 1 I think we'll leave it as-is/always-on for simplicity's sake.

@andrewazores andrewazores changed the title [proposal] Add more options for configs flexibility [Request] Deployment on non-root URL path, reintroduce Minimal deployment Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants