feat(ssl): Allow SSL Proxied EnvVars to be enabled outside of Ingress Configuration #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess Configuration
andrewazores
changed the title
ebaron
reviewed
Sep 30, 2022
There was a problem hiding this comment.
Hi @hgranillo, thank you so much for the contribution! This is something I hadn't considered and is an example of why it's great to hear from users on how they're deploying Cryostat.
I think the approach you've taken makes sense, I just have one suggestion below to account for an unusual use case.
ebaron
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #34
Hi cryostat helm chart maintainers!
This PR adds the ability to set up a parameter
core.sslProxiedin order to enable all the "SSL Proxied" environment variables outside of ingress/route tls configuration.The main reason behind this is that when you are offloading at the loadbalancer and not at the ingress you have no way currently to enable this settings in the current version of the chart.
I've tested this in my current deployment of cryostat and seems to work fine, I stopped receiving errors related to connection errors.