Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): call submodule update from release workflow #105

Merged
merged 1 commit into from
Dec 8, 2023
Merged

ci(release): call submodule update from release workflow #105

merged 1 commit into from
Dec 8, 2023

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Dec 8, 2023

Won't fix the problem for this release unfortunately.

Fixes: #104

@ebaron ebaron requested a review from andrewazores December 8, 2023 16:17
@mergify mergify bot added the safe-to-test label Dec 8, 2023
@andrewazores
Copy link
Member

Won't fix the problem for this release unfortunately.

We could delete the release and re-run the action, I think

@ebaron ebaron merged commit ed50629 into cryostatio:main Dec 8, 2023
7 of 10 checks passed
@ebaron
Copy link
Member Author

ebaron commented Dec 8, 2023

Won't fix the problem for this release unfortunately.

We could delete the release and re-run the action, I think

Let's give it a try, it would be nice to see this whole thing working end-to-end. We'll need to make sure the tag is deleted also.

mergify bot pushed a commit that referenced this pull request Dec 8, 2023
@ebaron @mergify
ci(release): call submodule update from release workflow (#105)
c5731c7 
(cherry picked from commit ed50629)
@mergify mergify bot mentioned this pull request Dec 8, 2023
Merged
andrewazores pushed a commit that referenced this pull request Dec 8, 2023
@mergify @ebaron
ci(release): call submodule update from release workflow (#105) (#106)
487a99a 
(cherry picked from commit ed50629)

Co-authored-by: Elliott Baron <[email protected]>
@ebaron
Copy link
Member Author

ebaron commented Dec 8, 2023

@Mergifyio backport gh-pages

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 8, 2023 •
edited
Loading

backport gh-pages

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 8, 2023
@ebaron @mergify
ci(release): call submodule update from release workflow (#105)
5c7717d 
(cherry picked from commit ed50629)

# Conflicts:
#	.github/workflows/helm-release.yml
@mergify mergify bot mentioned this pull request Dec 8, 2023
Closed
@ebaron
Copy link
Member Author

ebaron commented Dec 8, 2023

Won't fix the problem for this release unfortunately.

We could delete the release and re-run the action, I think

Let's give it a try, it would be nice to see this whole thing working end-to-end. We'll need to make sure the tag is deleted also.

There's also the chart index.yaml though:
05bba1e

That could pose a problem unless we revert it.

@andrewazores
Copy link
Member

Ah, right. I think just reverting that commit so the workflow action can redo it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport ci safe-to-test
Projects
No open projects
2.4.0 release
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Website submodule workflow does not trigger on release
2 participants
@ebaron @andrewazores