Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Fix the history not remembering the arguments for commands #334

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Fix the history not remembering the arguments for commands #334

merged 2 commits into from
Mar 7, 2022

Conversation

McModknower
Copy link
Contributor

Description
Fix the history not remembering the arguments for commands

Issue
Closes #332

Testing Instructions

  1. Start a terminal
  2. enter the command help
  3. enter the command help arg1 arg2
  4. enter the command history
  5. You should see both help commands and the second one with its arguments.

Additional Notes
During the testing of this, i discovered that the history command reverses the terminal history every time it is invoked. I will be fixing this in an upcoming Pull Request.

@Tristan-H11 Tristan-H11 enabled auto-merge (rebase) March 7, 2022 22:51
@Tristan-H11 Tristan-H11 requested review from MarcelCoding and a team March 7, 2022 22:52
@Tristan-H11 Tristan-H11 merged commit 4fe977c into cryptic-game:master Mar 7, 2022
@Tristan-H11 Tristan-H11 added this to the v0.3.0-pre-alpha milestone Mar 16, 2022
@66Ton99
Copy link

66Ton99 commented Oct 5, 2022

When do you plan to deploy it to the https://play.cryptic-game.net/ ?

@MarcelCoding
Copy link
Member

MarcelCoding commented Oct 5, 2022

It already should be. https://github.com/cryptic-game/frontend/releases/tag/v0.2.2 Third last entry of What's changed.

@MarcelCoding
Copy link
Member

oh, it is actually just released but not deployed... we missed that

@MarcelCoding
Copy link
Member

Now it should be deployed @66Ton99

@66Ton99
Copy link

66Ton99 commented Oct 7, 2022

@MarcelCoding it works now, but appear another problem #380

@66Ton99
Copy link

66Ton99 commented Oct 7, 2022

@McModknower nevermind, it works now

@66Ton99
Copy link

66Ton99 commented Oct 7, 2022

@McModknower this fix does not work any more :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command args do not get saved in the terminal history
5 participants