support include yaml #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pystarport serve --data=./data --config=cronos_has_dotenv.yaml --dotenv=overwrite.env
mmsqe
changed the title
|
This pull request introduces 3 alerts when merging 3c85574 into 4d8e677 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 92a434c into 4d8e677 - view on LGTM.com new alerts:
|
yihuang
reviewed
Apr 25, 2022
|
This pull request introduces 1 alert when merging 2bfcf6d into 4d8e677 - view on LGTM.com new alerts:
|
add pyyaml-include & mergedeep
mmsqe
changed the title
yihuang
reviewed
Apr 26, 2022
pyproject.toml
Outdated
| @@ -22,6 +22,8 @@ docker = "^4.3.1" | |||
| bech32 = "^1.1.0" | |||
| multitail2 = "^1.5.2" | |||
| python-dotenv = "^0.19.2" | |||
| pyyaml-include = "^1.3" | |||
| mergedeep = {git = "https://github.com/mmsqe/mergedeep.git", rev = "nested-merge"} | |||
There was a problem hiding this comment.
we already used a jsonmerge, what's the difference with this one?
There was a problem hiding this comment.
just more strategies, but can use without nested merge
yihuang
reviewed
Apr 26, 2022
pystarport/expansion.py
Outdated
|
|
||
| include = config.pop("include", {}) | ||
| if include: | ||
| config = merge(include, config, strategy=Strategy.ADDITIVE) |
There was a problem hiding this comment.
ADDITIVE sounds non-intuitive, I think people will expect REPLACE.
yihuang
reviewed
Apr 26, 2022
no change in dotenv func, but why deprecate it, no harms to keep? |
yihuang
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.