Jsonnet config #52
Merged
Jsonnet config #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* apply read symstem env with optional dotenv for .yaml * export VALIDATOR1_MNEMONIC=$VALIDATOR1_MNEMONIC && VALIDATOR2_MNEMONIC=$VALIDATOR2_MNEMONIC COMMUNITY_MNEMONIC=$COMMUNITY_MNEMONIC SIGNER1_MNEMONIC=$SIGNER1_MNEMONIC SIGNER2_MNEMONIC=$SIGNER2_MNEMONIC CRONOS_ADMIN=$CRONOS_ADMIN IBC_CRO_DENOM=$IBC_CRO_DENOM && poetry run pystarport serve --data=./data --config=pystarport/tests/test_expansion/cronos_has_posix_no_dotenv(*.yaml, *.jsonnet)
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
requested changes
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
yihuang
reviewed
Apr 29, 2022
| cronos_has_dotenv = parent / "cronos_has_dotenv.yaml" | ||
| cronos_no_dotenv = parent / "cronos_no_dotenv.yaml" | ||
| cronos_has_posix_no_dotenv = parent / "cronos_has_posix_no_dotenv.yaml" | ||
| for type in [".yaml", ".jsonnet"]: |
There was a problem hiding this comment.
Nit: looks like a good case to use https://docs.pytest.org/en/6.2.x/parametrize.html
There was a problem hiding this comment.
need call function, cant use parameter ar
There was a problem hiding this comment.
it'll run your test case once for each parameter automatically.
There was a problem hiding this comment.
seems can pass function as parameter
yihuang
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
LGTM.
Only one minor suggestion is use parametrized feature of pytest to structure the yaml/jsonnet test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.