-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: local state-sync commands are not integrated #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
May 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 45.82% 46.17% +0.34%
==========================================
Files 82 82
Lines 6937 6937
==========================================
+ Hits 3179 3203 +24
+ Misses 3422 3397 -25
- Partials 336 337 +1
|
yihuang
requested review from
JayT106,
devashishdxt and
mmsqe
and removed request for
a team
May 15, 2023 08:27
yihuang
commented
May 15, 2023
mmsqe
reviewed
May 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need add rpc_servers as well
Signed-off-by: yihuang <[email protected]>
Signed-off-by: yihuang <[email protected]>
13 tasks
mmsqe
reviewed
May 15, 2023
mmsqe
reviewed
May 15, 2023
Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]>
JayT106
approved these changes
May 15, 2023
mmsqe
reviewed
May 16, 2023
mmsqe
approved these changes
May 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
May 16, 2023
13 tasks
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)