Problem: no permissions system in cronos

[thomas-nguy]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

add the abilities to define admins that has priviledge to execute some admin functions

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

[codecov]

Codecov Report

Merging #795 (1de67b7) into main (62aab4c) will decrease coverage by 0.30%.
The diff coverage is 17.89%.

@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   36.76%   36.47%   -0.30%     
==========================================
  Files          55       56       +1     
  Lines        3979     4058      +79     
==========================================
+ Hits         1463     1480      +17     
- Misses       2345     2407      +62     
  Partials      171      171              

Impacted Files	Coverage Δ
versiondb/client/dump.go	0.00% <0.00%> (ø)
versiondb/extsort/sort.go	41.66% <ø> (ø)
x/cronos/keeper/grpc_query.go	0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go	15.71% <0.00%> (-1.21%)	⬇️
x/cronos/types/codec.go	0.00% <0.00%> (ø)
x/cronos/types/keys.go	0.00% <0.00%> (ø)
x/cronos/types/messages.go	11.97% <0.00%> (-2.42%)	⬇️
x/cronos/keeper/permissions.go	100.00% <100.00%> (ø)

[tomtau]

this is quite a big change -- could there first be a PR that just updates x/cronos's https://github.com/crypto-org-chain/cronos/tree/main/x/cronos/spec , so it's clearer what this is trying to do / what problem this is trying to solve? (I assume the spec won't be up to date if this is added?)

[thomas-nguy]

yes, you are totally right. I have created a PR to update the spec there
#801

[tomtau]

a few nits for considerations. Should the cronos module and/or protos be bumped to v2?

[mmsqe]

proto-check-breaking is red, you might try buf mod update

[thomas-nguy]

mmm seems that golangci-lint is failing after the change 7f12ef1#diff-107e910e9f2ebfb9a741fa10b2aa7100cc1fc4f5f3aca2dfe78b905cbd73c0d2

any clue @yihuang ?

[yihuang]

mmm seems that golangci-lint is failing after the change 7f12ef1#diff-107e910e9f2ebfb9a741fa10b2aa7100cc1fc4f5f3aca2dfe78b905cbd73c0d2

any clue @yihuang ?

strange, I can run locally though, there are some errors about sdkerrors deprecation.

[yihuang]

why not the ante handler return error instead of panic?
do we still need the CronosAdmin in parameters?

[thomas-nguy]

CronosAdmin is still needed for the sake of decentralisation. It is defined by governance and only the CronosAdmin can add/delete/update permissions

[yihuang]

CronosAdmin is still needed for the sake of decentralisation. It is defined by governance and only the CronosAdmin can add/delete/update permissions

oh, i thought the set permissios stuff is supposed to be controlled by gov

[thomas-nguy]

its controlled by the new MsgUpdatePermissions that only admin can use