Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: hash in subscribe newHeads differs from eth_getBlockByNumber #521

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 6, 2024

Closes: #XXX

instead of overwriting hash field, seems SetFmtHash in txhash-v038x also allow us align eth tx hash in long term


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 28 lines in your changes missing coverage. Please review.

Project coverage is 60.50%. Comparing base (452b0cf) to head (8ea16e2).

Files with missing lines Patch % Lines
rpc/stream/rpc.go 0.00% 18 Missing ⚠️
rpc/backend/blocks.go 50.00% 3 Missing and 3 partials ⚠️
rpc/backend/utils.go 80.00% 1 Missing and 1 partial ⚠️
rpc/types/utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    60.59%   60.50%   -0.10%     
===========================================
  Files          128      128              
  Lines         9724     9757      +33     
===========================================
+ Hits          5892     5903      +11     
- Misses        3255     3273      +18     
- Partials       577      581       +4     
Files with missing lines Coverage Δ
rpc/backend/utils.go 49.71% <80.00%> (+1.83%) ⬆️
rpc/types/utils.go 0.00% <0.00%> (ø)
rpc/backend/blocks.go 82.51% <50.00%> (-1.60%) ⬇️
rpc/stream/rpc.go 0.00% <0.00%> (ø)

@mmsqe mmsqe marked this pull request as ready for review September 10, 2024 15:36
@mmsqe mmsqe requested a review from yihuang September 10, 2024 15:36
@yihuang yihuang merged commit 3fabdbe into crypto-org-chain:develop Sep 11, 2024
36 of 39 checks passed
@yihuang yihuang deleted the new_heads branch September 11, 2024 06:02
mmsqe added a commit that referenced this pull request Sep 18, 2024
… (backport#521) (#525)

* Problem: hash in subscribe newHeads differs from eth_getBlockByNumber (#521)

* Problem: hash in subscribe newHeads differs from eth_getBlockByNumber

* fix test

* cleanup

* lint

* specify lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants