Refactor wallet creation to Wallet.create method #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansnigirev
force-pushed
the
wallet-create
branch
from
c277fa3 to
0122c37
Compare
ben-kaufman
approved these changes
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
.create()method forWalletandLWalletclasses.This simplifies logic in the wallet manager and allows separation of liquid-related blinding stuff to liquid wallet.
Introduces a few changes:
importdescriptorsorimportmultiare called directly fromWallet.createmethod so issues like Change descriptor sometimes(?) not imported #1214 should not happen any more.keypoolrefillonly callsimportmultisortedmultiaddresses in v19. I think it's time for everyone to upgrade, especially taking into account coming Taproot upgrade.