Fix for #2305 #2338
Closed
Fix for #2305 #2338
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't display button(Run the numbers) until sync is complete Prevent fetchTotalSupply() from running unless sync is complete
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
First public contribution - leave advice please |
|
Thanks! Tested, works! Sorry this took so long! For some reason the cypress tests are failing. We need to fix them for before the merge. |
k9ert
approved these changes
Jul 27, 2023
k9ert
reviewed
Sep 21, 2023
| @@ -39,6 +39,7 @@ | |||
| {% endif %} | |||
| <div class="px-3 pb-4"> | |||
| <p class="text-center text-sm m-4" id="total_supply"></p> | |||
| {% if verificationprogress >= 100 %} | |||
There was a problem hiding this comment.
File "/Users/kim/src/specter-desktop/src/cryptoadvance/specter/templates/includes/sidebar/components/node_connection.jinja", line 12, in top-level template code
<div class="hidden" id="node-info-popup">{% include node.node_info_template() %}</div>
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/kim/src/specter-desktop/src/cryptoadvance/specter/templates/node/components/bitcoin_core_info.jinja", line 42, in top-level template code
{% if verificationprogress >= 100 %}
^^^^^^^^^^^^^^^^^^^^^^^^^
jinja2.exceptions.UndefinedError: 'verificationprogress' is undefined
That's what the tests are complaining about. Why do you think it's defined?
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
already done in #2457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't display button(Run the numbers) until sync is complete
Prevent fetchTotalSupply() from running unless sync is complete