ur:crypto-psbt support #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern ur:crypto-psbt standard support for QR codes. Experimental.
Close #89.
I had to write it from scratch as implementation from foundation devices uses too much memory.
Tested with small to mid-size transactions (up to 10 inputs) - works in most cases.
Sometimes it fails on large txs for mysterious reasons - decoder probably because of uart buffer overwrite, not sure why encoder fails. I need to investigate further.
Anyways, for most common txs it works, so makes sense to gather information when it fails and under what conditions.