Partial removal of Circular parameters dependency #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implicitly a curve based operation, and not relevant to the Point. Arguably a lot of the math curve context is also, but, that is not as easy to extract yet.
jprichardson
added a commit
that referenced
this pull request
Jun 10, 2014
Partial removal of Circular parameters dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this pull request is clear from the IRC discussion, but some things to note are that in this PR we have lost the 'generic' form of a
Curvein that it is now specific toECCby having the curve parameters necessary for construction. This was technically already necessary, but was hidden behind small hacks like thetacked onparamsvariable innames.js.Like the other PR, this is API breaking.