Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve the problem mentioned in #17 (comment):
Using sealed classes and IoC, we can now let the implementation decide, which kind of icon it needs, e.g.
On the consumer side, invocation would look like this:
Note that the consumer is only required to implement loaders permitted by the sealed interface, so there can only be as many required implementation as the API allows:
integrations-api/src/main/java/org/cryptomator/integrations/tray/TrayIconLoader.java
Line 6 in cdf313e
When the API is updated, new implementations can be added without breaking previous ones. With JEP 433, one will even get a compiler error due to exhaustiveness checks, if an implementation is missing.