Integrated Service Loading #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| WINDOWS, | ||
| UNKNOWN; | ||
|
|
||
| private static final String OS_NAME = System.getProperty("os.name").toLowerCase(); |
There was a problem hiding this comment.
NULL_DEREFERENCE: object returned by getProperty("os.name") could be null and is dereferenced at line 33.
(at-me in a reply with help or ignore)
infeo
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves service loading by adding an
IntegrationsLoaderthat uses annotations to sort and filter implementation candidates.Furthermore static "factory" methods have been added to all current services.
Sorting
Using the
@Priority(42)annotation, we can make a certain service implementation take precedence over others, allowing us to implement fallback mechanisms easily.Filtering
This allows us (to a certain degree) to check whether a certain service implementation is suited for e.g. the current operating system (using the
@OperatingSystem(Value.Windows)annotation) without actually creating an instance of said service. Further discriminators may be added on demand eventually.