Feature: Add a description field for calendar events #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chouhartem
added
Feature Request
davidbenque
changed the title
…urpose of creating and updating the calendar event. BUG: carriage returns don't seem to work WIP: the text is hardcoded as of now, have to use Messages library for translations.
* Rename description in the schedule object -> Use the body property of [tui-calendar](https://github.com/nhn/tui.calendar/) for to show the description in the details popup : <https://github.com/nhn/tui.calendar/blob/main/docs/en/apis/template.md#popupdetailbody>
* Sanitized markdown raises a warning:
```
marked(): sanitize and sanitizer parameters are deprecated since version
0.7.0, should not be used and will be removed in the future.
Read more here:
https://marked.js.org/#/USING_ADVANCED.md#options
marked.min.js:6:44783
```
Lint compliance for the calendar description field (#1171)
* Inlined at the beginning of `www/calendar/inner.js` for future integration in weblate on release.
Descriptions can be long and RFC5545 states that a line shouldn't be more than 75 bytes long.
According to [RFC5545](https://www.rfc-editor.org/rfc/rfc5545#section-3.1): ``` Note: It is possible for very simple implementations to generate improperly folded lines in the middle of a UTF-8 multi-octet sequence. For this reason, implementations need to unfold lines in such a way to properly restore the original sequence. ``` It actually happens when an emoji takes the 75th and 76th bit.
body was a wrong choice of name
An issue when getting back the content of an edited only recurring event
Chouhartem
force-pushed
the
feature-calendar-description
branch
from
7a3279e to
66a2815
Compare
|
Hello, I rebased with staging, integrated the changes that have been made and add the following features:
|
Chouhartem
added a commit
to Chouhartem/cryptpad
that referenced
this pull request
Dec 6, 2023
…n the popup Related to cryptpad#1299 + cryptpad#1171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Two new descriptions keys :
calendar_descandcalendar_descriptionare to be added upon version release.