Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let .. = .. else { .. } #155

Closed
W95Psp opened this issue Jun 23, 2023 · 1 comment · Fixed by #779
Closed

let .. = .. else { .. } #155

W95Psp opened this issue Jun 23, 2023 · 1 comment · Fixed by #779
Assignees
@maximebuyse
Labels
engine Issue in the engine good first issue Good for newcomers marked-unimplemented Issue refered by `Unimplemented {issue_id...}` in the engine unsupported-rust Rust code rejected by hax. Unless marked wontfix, we want to support it soon.

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Jun 23, 2023

See https://doc.rust-lang.org/rust-by-example/flow_control/let_else.html.

I think we should just transform those into matches.
@W95Psp W95Psp added engine Issue in the engine marked-unimplemented Issue refered by `Unimplemented {issue_id...}` in the engine labels Jun 23, 2023
@W95Psp W95Psp self-assigned this Jun 23, 2023
@franziskuskiefer franziskuskiefer moved this to Todo in hax Aug 21, 2023
@W95Psp
Copy link
Collaborator Author

W95Psp commented Aug 21, 2023 •
edited
Loading

This was fixed by cc70907
oops, this was for let if

@W95Psp W95Psp closed this as completed Aug 21, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in hax Aug 21, 2023
@W95Psp W95Psp reopened this Aug 21, 2023
@W95Psp W95Psp added the good first issue Good for newcomers label Aug 21, 2023
@franziskuskiefer franziskuskiefer moved this from Done to Todo in hax Aug 21, 2023
@W95Psp W95Psp changed the title Support let-else expressions let .. = .. else { .. } Jan 5, 2024
@W95Psp W95Psp added the unsupported-rust Rust code rejected by hax. Unless marked wontfix, we want to support it soon. label Jan 5, 2024
W95Psp added a commit to cryspen/sandwich that referenced this issue Jun 11, 2024
@W95Psp
fix(hax): rewrite unsupported rust constructs
15598eb 
 - `let ... else {...}` is not supported yet (see cryspen/hax#155);
 - `return` inside a loop is not supported yet (see cryspen/hax#196).
W95Psp added a commit to cryspen/sandwich that referenced this issue Jun 11, 2024
@W95Psp
fix(hax): rewrite unsupported rust constructs
bd84a5d 
 - `let ... else {...}` is not supported yet (see cryspen/hax#155);
 - `return` inside a loop is not supported yet (see cryspen/hax#196).
@maximebuyse maximebuyse mentioned this issue Jul 17, 2024
Merged
@maximebuyse maximebuyse assigned maximebuyse and unassigned W95Psp Jul 17, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in hax Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximebuyse maximebuyse

Labels
engine Issue in the engine good first issue Good for newcomers marked-unimplemented Issue refered by `Unimplemented {issue_id...}` in the engine unsupported-rust Rust code rejected by hax. Unless marked wontfix, we want to support it soon.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support let-else pattern. cryspen/hax
2 participants
@W95Psp @maximebuyse