Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proverif_before!, proverif_after!, proverif_replace! are not working #620

Closed
W95Psp opened this issue Apr 23, 2024 · 5 comments
Closed

proverif_before!, proverif_after!, proverif_replace! are not working #620

W95Psp opened this issue Apr 23, 2024 · 5 comments

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Apr 23, 2024

PR #614 adds support for new ways of inlining backend code within Rust.
In the ProVerif backend, certain kinds of items (e.g. Fn vs Type) are outputted in different parts of the output pv files.

I suspect we need to add a proverif_options field to ItemQuote to allow the user to place the item. Or maybe we should just inherit the position of the item the attribute was on?

@jschneider-bensch what do you think?

Copy link

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@jschneider-bensch
Copy link
Contributor

Need to look into the necessary changes a bit more, but should address this, since it would be good to have e.g. when addressing cryspen/bertie#116.

Copy link

github-actions bot commented Nov 2, 2024

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 2, 2024
Copy link

This issue has been closed due to a lack of activity since being marked as stale. If you believe this issue is still relevant, please reopen it with an update or comment.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2024
@W95Psp W95Psp removed the stale label Nov 18, 2024
@W95Psp W95Psp reopened this Nov 18, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Nov 18, 2024

@W95Psp W95Psp closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants