Merge pull request #530 from crystal-ameba/fix-dot-formatter-failures…

…-count

spec/ameba/formatter/dot_formatter_spec.cr

@@ -5,6 +5,10 @@ module Ameba::Formatter
     output = IO::Memory.new
     subject = DotFormatter.new output
 
+    before_each do
+      output.clear
+    end
+
     describe "#started" do
       it "writes started message" do
         subject.started [Source.new ""]
@@ -51,7 +55,6 @@ module Ameba::Formatter
         end
 
         it "writes affected code by default" do
-          output.clear
           s = Source.new(%(
             a = 22
             puts a
@@ -65,7 +68,6 @@ module Ameba::Formatter
         end
 
         it "writes severity" do
-          output.clear
           s = Source.new(%(
             a = 22
             puts a
@@ -78,7 +80,6 @@ module Ameba::Formatter
         end
 
         it "doesn't write affected code if it is disabled" do
-          output.clear
           s = Source.new(%(
             a = 22
             puts a
@@ -95,11 +96,14 @@ module Ameba::Formatter
         end
 
         it "does not write disabled issues" do
-          s = Source.new ""
-          s.add_issue(DummyRule.new, location: {1, 1},
-            message: "DummyRuleError", status: :disabled)
+          s = Source.new("").tap do |source|
+            source.add_issue(DummyRule.new, {1, 1}, "DummyRuleError", status: :disabled)
+            source.add_issue(NamedRule.new, {1, 2}, "NamedRuleError")
+          end
           subject.finished [s]
-          output.to_s.should contain "1 inspected, 0 failures"
+          log = output.to_s
+          log.should_not contain "DummyRuleError"
+          log.should contain "1 inspected, 1 failure"
         end
       end
     end

src/ameba/formatter/dot_formatter.cr

@@ -100,7 +100,7 @@ module Ameba::Formatter
 
     private def final_message(sources, failed_sources)
       total = sources.size
-      failures = failed_sources.sum(&.issues.size)
+      failures = failed_sources.sum(&.issues.count(&.enabled?))
       color = failures == 0 ? :green : :red
       s = failures != 1 ? "s" : ""