Merge pull request #498 from crystal-ameba/dont-use-thread-mutex

Misc refactors

src/ameba/config.cr

@@ -87,7 +87,7 @@ class Ameba::Config
   property? autocorrect = false
 
   # Returns a filename if reading source file from STDIN.
-  property stdin_filename : String? = nil
+  property stdin_filename : String?
 
   @rule_groups : Hash(String, Array(Rule::Base))
 

src/ameba/formatter/base_formatter.cr

@@ -19,10 +19,14 @@ module Ameba::Formatter
 
     # Callback that indicates when source inspection is started.
     # A corresponding source is passed as an argument.
+    #
+    # WARNING: This method needs to be MT safe
     def source_started(source : Source); end
 
     # Callback that indicates when source inspection is finished.
     # A corresponding source is passed as an argument.
+    #
+    # WARNING: This method needs to be MT safe
     def source_finished(source : Source); end
 
     # Callback that indicates when inspection is finished.

src/ameba/formatter/dot_formatter.cr

@@ -7,7 +7,7 @@ module Ameba::Formatter
     include Util
 
     @started_at : Time::Span?
-    @mutex = Thread::Mutex.new
+    @mutex = Mutex.new
 
     # Reports a message when inspection is started.
     def started(sources)

src/ameba/formatter/todo_formatter.cr

@@ -3,7 +3,9 @@ module Ameba::Formatter
   # Basically, it takes all issues reported and disables corresponding rules
   # or excludes failed sources from these rules.
   class TODOFormatter < DotFormatter
-    def initialize(@output = STDOUT, @config_path : Path = Config::DEFAULT_PATH)
+    @config_path : Path
+
+    def initialize(@output = STDOUT, @config_path = Config::DEFAULT_PATH)
     end
 
     def finished(sources)