Fixes #4060 (#4068)

Extra byte evaluated to truthy with an empty slice. Added size check which fixes the gzip bug.
crystal-lang · Mar 1, 2017 · 2e61cca · 2e61cca
1 parent f58fd86
commit 2e61cca
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/gzip/header.cr b/src/gzip/header.cr
@@ -71,7 +71,7 @@ class Gzip::Header
 
     # flg
     flg = Flg::None
-    flg |= Flg::EXTRA if @extra
+    flg |= Flg::EXTRA unless @extra.empty?
     flg |= Flg::NAME if @name
     flg |= Flg::COMMENT if @comment
     io.write_byte flg.value
@@ -85,9 +85,9 @@ class Gzip::Header
     # os
     io.write_byte os
 
-    if extra = @extra
-      io.write_byte extra.size.to_u8
-      io.write(extra)
+    unless @extra.empty?
+      io.write_byte @extra.size.to_u8
+      io.write(@extra)
     end
 
     if name = @name