You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
WebSocket#run currently catches an IO::EOFError, and calls the on_close handler. Should this happen with other exceptions where the socket is closed, for example connection reset by peer?
The text was updated successfully, but these errors were encountered:
I'm not sure, I think we are missing an exception handler above that and an on_error or something like that. The websocket code is pretty young and misses a lot of things, probably also a way to use it without callbacks.
Maybe on_close should only be called when the "close" message type is received. This keeps it's function specific and well-defined. Other errors should propagate up and be handled by the #run caller.
WebSocket#run
currently catches anIO::EOFError
, and calls the on_close handler. Should this happen with other exceptions where the socket is closed, for example connection reset by peer?The text was updated successfully, but these errors were encountered: