Correctly support websocket close codes #8975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
added
kind:bug
asterite
reviewed
Mar 30, 2020
|
Added |
Sija
reviewed
Mar 30, 2020
|
Just for the reference, here it is a list of error codes from IANA -> https://www.iana.org/assignments/websocket/websocket.xhtml#close-code-number |
|
This is essentially a bug in websockets right now, so I'd really like if this could make it into 0.34.0 because it's affecting a number of people I know. Changes to accept an enum could be made later. If the constant styling is unacceptable to the core team I'm happy to change it, but it'd be nice to merge this as-is right now... |
bcardiff
approved these changes
Apr 1, 2020
The first two bytes of the message in a WebSocket Close frame is a numeric code. Make sure to always encode this correctly, to avoid being in violation of the websocket spec. Also automatically decode this for clients. This is a breaking change since on_close now takes two arguments: close code and message, but this change was unable to be made in a backwards compatible way. Closes crystal-lang#6469 Closes crystal-lang#7483
RX14
force-pushed
the
feature/websocket-close-codes
branch
from
d2c35ec to
46723ce
Compare
|
Squashed and added the extra close codes from the registry. I'll merge this once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two bytes of the message in a WebSocket Close frame is anumeric code. Make sure to always encode this correctly, to avoid being in violation of the websocket spec. Also automatically decode this for clients.
This is a breaking change since on_close now takes two arguments: close code and message, but this change is unable to be made in a backwards compatible way.
Closes #6469