Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter is broken with absolute paths #7559

Closed
RX14 opened this issue Mar 16, 2019 · 1 comment
Closed

Formatter is broken with absolute paths #7559

RX14 opened this issue Mar 16, 2019 · 1 comment

Comments

@RX14
Copy link
Contributor

RX14 commented Mar 16, 2019 •
edited
Loading

Passing absolute paths to the formatter fails with

$ crystal tool format /data/programming/crystal-lang/beryl/master/src/i3bar.cr
Error: file or directory does not exist: .//data/programming/crystal-lang/beryl/master/src/i3bar.cr

I'm surprised nobody's noticed in the past month...
@RX14
Copy link
Contributor Author

RX14 commented Mar 16, 2019

In fact it seems to me it was broken in #4635, almost a year old. Since emacs-crystal-mode's autoformat scrpt generates tempfiles in /tmp, this should have been triggering the bug for an entire year, but it's only popped up now, hmm

RX14 added a commit to RX14/crystal that referenced this issue Mar 16, 2019
@RX14
Fix formatting absolute paths
eac4b35 
Fixes crystal-lang#7559
@RX14 RX14 mentioned this issue Mar 16, 2019
Merged
straight-shoota pushed a commit that referenced this issue Mar 17, 2019
@RX14 @straight-shoota
Fix formatting absolute paths (#7560)
d4ded5c 
Fixes #7559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RX14