Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract libunwind from callstack #11205

Merged

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Sep 13, 2021

Move platform-specific code for libunwind from call_stack to call_stack/libunwind.

This is a preparotory step for implementing callstack unwinding for win32.

It's just code relocation. There are no semantical changes.

@straight-shoota straight-shoota added kind:refactor platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:runtime labels Sep 13, 2021
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@straight-shoota straight-shoota added this to the 1.2.0 milestone Sep 13, 2021
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 🙏

@straight-shoota straight-shoota merged commit edef02b into crystal-lang:master Sep 15, 2021
@straight-shoota straight-shoota deleted the refactor/libunwind branch September 15, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:refactor platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants