Add bindings to __fxstat and __lxstat for x86_64-linux-gnu
#11361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, the symbols
fstatandlstatare not part of the GNUlibc.soshared library, and instead provided bylibc_noshared.a. That makes them unavailable for dynamic runtime symbol lookup viadlsymwhich we use for interpreted mode.See #11157 (comment) for details.
The symbols
__fxstatand__lxstatare the internal counterparts and should be available in any GNUlibc.so. Thus it makes sense to link against those directly (which would otherwise happen throughlibc_noshared.a) because that works both in interpreted and compiled mode.GNU libraries on other architectures (especially
aarch64) might be similarly affected, but I couldn't verify that yet.Resolves #11157