Improve search input a11y for generated docs #11604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve color contrast of search input placeholder in docs according to the W3C's [WCAG specification](https://www.w3.org/TR/WCAG21/) color contrast recommendations.
|
I'm not sure about making it a flat black. Maybe some shade in between might be nicer to indicate it's a placeholder, not a value. |
`#757575` is about the lightest color that passes the WCAG AA color contrast recommendation on a white background with text of a normal font weight.
|
|
straight-shoota
approved these changes
Dec 20, 2021
straight-shoota
added
kind:bug
oprypin
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve color contrast of search input placeholder in docs according to the W3C's WCAG specification color contrast recommendations.
Extant color contrast is a ratio of 1.7:1, below the minimum "WCAG A" color contrast recommendation. Notice the "Search..." placeholder is barely visible in this screenshot:
