Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for String#char_bytesize_at #11872

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Add specs for String#char_bytesize_at #11872

merged 1 commit into from
Jun 28, 2022

Conversation

straight-shoota
Copy link
Member

This patch adds some specs for String#char_bytesize_at to validate the UTF-8 sequence algorithm is correct.

@straight-shoota straight-shoota mentioned this pull request Mar 5, 2022
Closed
sdogruyol
sdogruyol approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @straight-shoota 🙏

@straight-shoota straight-shoota added this to the 1.5.0 milestone Jun 26, 2022
@straight-shoota straight-shoota merged commit 92f9e23 into crystal-lang:master Jun 28, 2022
@straight-shoota straight-shoota deleted the spec/string-char_bytesize_at branch June 28, 2022 20:47
asterite pushed a commit that referenced this pull request Jun 29, 2022
@straight-shoota
Add specs for String#char_bytesize_at (#11872)
39edcc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:specs topic:stdlib:text
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @sdogruyol