Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip hostname spec if hostname command fails #12987

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Skip hostname spec if hostname command fails #12987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e915b77
Ensure `hostname` command exists before running spec that uses it
Blacksmoke16 Jan 21, 2023
f034550
Skip spec if the command fails versus just not present
Blacksmoke16 Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spec/std/system_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ describe System do
describe "hostname" do
pending_win32 "returns current hostname" do
shell_hostname = `hostname`.strip
$?.success?.should be_true # The hostname command has to be available
pending! "`hostname` command was unsuccessful" unless $?.success?

hostname = System.hostname
hostname.should eq(shell_hostname)
end
Expand Down