Fix preview_mt
infinite loop on Windows
#13419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #13362, all programs on Windows will get stuck while initializing constants if
-Dpreview_mt
is provided:Crystal::OnceState#once
callsMutex#lock
Fiber.current
Crystal::Scheduler.current_fiber
Thread#scheduler
Crystal::Scheduler.new
@fiber_channel
by callingCrystal::FiberChannel.new
@worker_out
and@worker_in
by callingIO.pipe
Crystal::System::FileDescriptor.pipe
Crystal::OnceState#once
This PR breaks the loop so that programs will at least continue to run with
-Dpreview_mt
(and work as long as no concurrency or multithreading features are used).