Fix System V ABI for packed structs with misaligned fields #14324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9873. Section 3.2.3 of the System V ABI reference says: (emphasis own)
The same behavior is verified with C on Clang. Actually calling
Proc
s that take or return those misaligned structs will most likely require #14323 as well, asbyval
andsret
are now mandatory.On an unrelated note: while the reference says "eight eightbytes", an earlier revision said "four" instead, which is what Crystal currently uses for classification. This probably won't matter unless Crystal supports 512-bit vectors natively.