WebSocket: Add support for receiving binary messages #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,6 +76,12 @@ class HTTP::WebSocket | |||
| @on_message.try &.call(@current_message.to_s) | |||
| @current_message.clear | |||
| end | |||
| when Protocol::Opcode::BINARY | |||
| @current_message.write @buffer[0, info.size] | |||
There was a problem hiding this comment.
I know nothing about the websocket protocol, so excuse me in case it's obvious. So binary message are too at maximum 4096 bytes big?
Er, nvm, I shouldn't look at stuff anymore today.
|
I know there are no existing specs for this area of the code, would you mind looking into adding one for this nonetheless? Otherwise LGTM. |
Sija
reviewed
Apr 4, 2017
| @@ -40,6 +40,9 @@ class HTTP::WebSocket | |||
| def on_message(&@on_message : String ->) | |||
| end | |||
|
|
|||
| def on_binary(&@on_binary : Slice(UInt8) ->) | |||
|
Let's merge this, if there are things to improve we can do it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not an ideal implementation, it would be better if the
on_binaryblock received some kind of IO that could be read while each part of the binary message arrives instead. I'll do that at a later moment. Either way, this is at least working.