Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UUID Update #2862

Closed
wants to merge 8 commits into from
Closed

UUID Update #2862

wants to merge 8 commits into from

Conversation

jkthorne
Copy link
Contributor

This is a bump/update to #2716

@ysbaddaden
Copy link
Contributor

Could you squash all the src/uuid/* files into a single src/uuid.cr file?

ysbaddaden
ysbaddaden reviewed Jun 17, 2016
View reviewed changes
src/uuid/empty.cr
@@ -0,0 +1,14 @@
struct UUID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about?

module UUID
  NIL = UUID.new(StaticArray(UInt8, 16).new)
end

I don't see a use case for the empty! method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the empty is there a reason why you put in module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a use case for an empty UUID?

@jkthorne jkthorne closed this Oct 18, 2016
@jkthorne jkthorne deleted the uuid branch May 23, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic:stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkthorne @ysbaddaden @jhass @asterite @mirek