-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UUID continuation #4453
Merged
Merged
UUID continuation #4453
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
3b1bae7
Add `UUID`.
mirek f0bb4d8
Rearrange structure to separate RFC4122 logic.
mirek a9019b6
Updates.
mirek cbfd749
Merge branch 'master' into uuid
mirek a2e23a3
Merge branch 'master' into uuid
mirek 3d69d69
Merge remote-tracking branch 'origin/master' into uuid
133e84d
remove uuid from prelude; update for moden build for crystal
c6a9604
Merge remote-tracking branch 'origin/master' into uuid
0ca59d6
Use `should` and `eq` instead of checking against true
jkthorne 2d881d9
fix typo
jkthorne e48a7d5
Doc fix
jkthorne a48e4fb
Change the implimintation of UUID::EMPTY
jkthorne 64e64f7
Update Docs
jkthorne df3fd11
Merge branch 'master' into uuid
55ad17a
Change formatting form to_s to methods
c1cf14d
Merge branch 'uuid' of github.com:wontruefree/crystal into uuid
8295cfa
wip
b7c17f3
wip
c6b781c
remove trasition to Random
jkthorne 8fee1b6
add bytes to initialize
jkthorne f72b57b
remove class level variant functions
jkthorne 7139655
Merge branch 'master' into uuid
jkthorne f3fce3d
update hex pair check to use String std
dfbc0c1
Merge branch 'master' into uuid
jkthorne a71f569
Merge branch 'uuid' of github.com:wontruefree/crystal into uuid
jkthorne 41302ca
Merge remote-tracking branch 'upstream/master' into uuid
0f7d36f
cleanup some code left over from wip
9242f73
Merge remote-tracking branch 'upstream/master' into uuid
baa9277
move to initialize from new and be more explicit about the setup
e34308e
Merge branch 'uuid' of github.com:wontruefree/crystal into uuid
5dce117
Merge remote-tracking branch 'upstream/master' into uuid
ad9a37f
Merge remote-tracking branch 'upstream/master' into uuid
509ff75
Merge remote-tracking branch 'upstream/master' into uuid
e55718d
Merge remote-tracking branch 'upstream/master' into uuid
4cfd90e
Merge remote-tracking branch 'upstream/master' into uuid
79f5b7d
Merge remote-tracking branch 'upstream/master' into uuid
7b4b9ad
condense uuid files
2cae97a
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne f369a34
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne b325f3d
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne ac2d176
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 9290bf7
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 6044754
Move uuid functions into one file.
jkthorne 627a8e1
linter
jkthorne cc14710
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 8ff542e
remove secure_random
jkthorne 8639668
linter
jkthorne 8d25980
remove Random uuid
jkthorne 8062232
remove `<<` and extra `==` methods
jkthorne 8f47d38
revert linter commits
jkthorne d79b51f
use safer copy for UUID initilaize
jkthorne 9828bd7
add safer copy with slice intialize
jkthorne 0366f78
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 409fe5b
rework UUID intialize and add more tests
jkthorne e3bee29
change string to be made without unsafe methods
jkthorne 49a6372
reorder methods and make to_slice safe
jkthorne 17ddbbf
add specs for default initialize
jkthorne f282061
remove periods from comments
jkthorne a80ff09
remove periods from error messages
jkthorne b4f1340
remove whitespace
jkthorne 4669f9a
revert comment changes
jkthorne 1c3e811
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 3addefc
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 30db4ad
changing to Random for performance
jkthorne eec5ece
Revert "changing to Random for performance"
jkthorne 494d20b
add random over new
jkthorne 6a25156
move class methods together
jkthorne 264f729
Merge remote-tracking branch 'upstream/master' into uuid
jkthorne 6a143fa
change uuid to use secure random
jkthorne 1c8db2b
Make UUID immutable, and not overwrite the version and variant
RX14 3712820
Docs fixes
RX14 f6f6070
Add constructor to initialize from UUID
RX14 122f84b
Remove magic equality with String
RX14 c496177
UUID#to_s cleanup
RX14 9c49e7b
Clarify doc for UUID.new(UUID, ...)
RX14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I said exactly my reasoning above, it's magic, and costly, and unexpected.
Considering also the constraint that
x == y
impliesx.hash == y.hash
then we'd have to implement hash usingto_s
too, which is costly even if you don't use this.