[WIP] Introduce crystal --fake_source=sourcepath flag #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Jun 14, 2017
src/compiler/crystal/command.cr
Outdated
| @@ -450,6 +450,9 @@ class Crystal::Command | |||
| end | |||
|
|
|||
| private def gather_sources(filenames) | |||
| if ENV.has_key?("CRYSTAL_FAKE_SOURCE_FILENAME") | |||
There was a problem hiding this comment.
I'd suggest getting rid of extra ENV#[] call, like:
if fake_source_filename = ENV["CRYSTAL_FAKE_SOURCE_FILENAME"]?
return [Compiler::Source.new(fake_source_filename, STDIN.gets_to_end)]
endThere was a problem hiding this comment.
just reworked as --fake-source flag. looks cleaner.
|
This seems like a weird solution. I don't mind |
akzhan
force-pushed
the
introduce-CRYSTAL_FAKE_SOURCE_FILENAME-env-var
branch
from
0926c89 to
0589534
Compare
akzhan
changed the title
akzhan
changed the title
|
@RX14 Yes, it is just a proposal (how to implement). Now it is Feel free to rework. |
akzhan
changed the title
akzhan
force-pushed
the
introduce-CRYSTAL_FAKE_SOURCE_FILENAME-env-var
branch
from
4ef7d90 to
1bd3250
Compare
|
Followed with #4571 with cleaner code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to compile source from STDIN, closes #4561.
Synopsys
cat src/math/math.cr | ./bin/crystal build --no-codegen --no-color -o /dev/null -f json --fake-source src/math/math.cr