-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format: indent multiline call chaining with 4 spaces #5234
Format: indent multiline call chaining with 4 spaces #5234
Conversation
I just wonder how easy it will be to make this kind of exception in the editors. Not all use the builtin formatter by default. |
@yxhuvud they should. But I think this rule is easy to apply while typing too. It's just when the line starts with a |
ping |
I quote and support @asterite : "I think the formatter should always use 2 spaces to indent." This is what I always use: 2 spaces.
This is unwelcomed, and one more reason to not use the formatter. |
Hm, @ysbaddaden's opinion makes sense. Do you have a counter, @RX14, @straight-shoota or any one? |
@ysbaddaden it's not a big deal, but I outlined by argument here. If everyone else agrees that an indent of 2 is fine, let's merge this PR with that. |
03d1879
to
4ab32d1
Compare
@RX14 changed indent size as 2 spaces. |
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this basically removes the feature of the formatter aligning calls to the dot, right? If so, I think that's fine. More consistent (always 2 spaces for indent), less discussions.
4ab32d1
to
fe8d3b4
Compare
Fixed crystal-lang#8197 Also remove @multiline_call_indent trick introduced by crystal-lang#5234. It was originally introduced for dot alignment as @dot_column. However it is removed and this trick can be implemented without any trick.
Closes #5195
See #5195 (comment)